Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade indexer errors #675

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Downgrade indexer errors #675

merged 3 commits into from
Sep 4, 2024

Conversation

jamiehewitt15
Copy link
Member

@jamiehewitt15 jamiehewitt15 commented Sep 4, 2024 •
edited
Loading

Fixes #672

Changes proposed in this PR:

  • Issue with getting events is now a warning rather than an error
  • "INDEXER_NETWORKS is not defined" is not an error, it is now shown as INFO

@jamiehewitt15 jamiehewitt15 marked this pull request as ready for review September 4, 2024 11:23
@jamiehewitt15 jamiehewitt15 self-assigned this Sep 4, 2024
mariacarmina
mariacarmina approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

paulo-ocean
paulo-ocean approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
btw, we can also always use the shortcut functions versions (less verbose)
like:

INDEXER_LOGGER.warn()
INDEXER_LOGGER.error()

etc

@jamiehewitt15 jamiehewitt15 merged commit ebdec2a into main Sep 4, 2024
12 checks passed
@jamiehewitt15 jamiehewitt15 deleted the issue-672-downgrade-rpc-errors branch September 4, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@mariacarmina mariacarmina mariacarmina approved these changes

@alexcos20 alexcos20 alexcos20 approved these changes

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

Assignees

@jamiehewitt15 jamiehewitt15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark RPC errors as warnings
4 participants
@jamiehewitt15 @alexcos20 @mariacarmina @paulo-ocean