Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing IP address & adjusting UI #667

Merged
merged 4 commits into from
Sep 4, 2024
Merged

removing IP address & adjusting UI #667

merged 4 commits into from
Sep 4, 2024

Conversation

jamiehewitt15
Copy link
Member

@jamiehewitt15 jamiehewitt15 commented Aug 30, 2024 •
edited
Loading

Fixes #629

Changes proposed in this PR:

  • removing IP address
  • adjusting UI to remove the empty column on the right.

image

@jamiehewitt15 jamiehewitt15 marked this pull request as ready for review August 30, 2024 13:25
paulo-ocean
paulo-ocean approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
btw, not sure if we need to shorten the node ids, its public data and we have a lot of space on the page anyway

@jamiehewitt15
Copy link
Member Author

LGTM btw, not sure if we need to shorten the node ids, its public data and we have a lot of space on the page anyway

Yeah good point, I will remove that. Much better to see the whole string given that we have the space.

@jamiehewitt15 jamiehewitt15 merged commit e6e3afd into main Sep 4, 2024
12 checks passed
@jamiehewitt15 jamiehewitt15 deleted the issue-629-IP branch September 4, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@alexcos20 alexcos20 alexcos20 approved these changes

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node http up IP
3 participants
@jamiehewitt15 @alexcos20 @paulo-ocean