Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on connection reset - P2P streams #659

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Fix crash on connection reset - P2P streams #659

merged 3 commits into from
Sep 4, 2024

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Aug 28, 2024 •
edited
Loading

Fixes #644

Changes proposed in this PR:

  • check stream status before write
  • close stream once done
  • use async override for 'pipe'

@paulo-ocean paulo-ocean self-assigned this Aug 28, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review August 28, 2024 13:12
@alexcos20
Copy link
Member

pulled oceanprotocol/ocean-node:pr-659 on my raspb..
I will keep it running over night and see

alexcos20
alexcos20 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, node is up, no cpu issues

jamiehewitt15
jamiehewitt15 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks good

@paulo-ocean paulo-ocean merged commit 1404482 into main Sep 4, 2024
12 checks passed
@paulo-ocean paulo-ocean deleted the issue-644-crash-stream-reset branch September 4, 2024 08:17
@paulo-ocean paulo-ocean mentioned this pull request Sep 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@alexcos20 alexcos20 alexcos20 approved these changes

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node crash
4 participants
@paulo-ocean @alexcos20 @bogdanfazakas @jamiehewitt15