Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing/invalid db_url log message, put warn at startup #654

Merged
merged 5 commits into from
Oct 2, 2024
Merged

fix missing/invalid db_url log message, put warn at startup #654

merged 5 commits into from
Oct 2, 2024

Conversation

paulo-ocean
Copy link
Contributor

Fixes #630

Changes proposed in this PR:

  • fix log message
  • re-check logic

@paulo-ocean paulo-ocean self-assigned this Aug 27, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review August 27, 2024 16:43
bogdanfazakas
bogdanfazakas approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulo-ocean paulo-ocean merged commit 3ea7e0e into main Oct 2, 2024
11 checks passed
@paulo-ocean paulo-ocean deleted the issue-630-fix-log-msg branch October 2, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@alexcos20 alexcos20 alexcos20 approved these changes

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing info: Indexer will not be enabled
3 participants
@paulo-ocean @alexcos20 @bogdanfazakas