Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard transfer collected fees #633

Merged
merged 5 commits into from
Aug 30, 2024

Conversation

jamiehewitt15
Copy link
Member

Fixes #295

Changes proposed in this PR:

  • Adding new feature in the dashboard allowing the user to transfer the collected fees.

It can be tested using the tokens (e.g. Ocean or MockDai) that are deployed via barge.

image

Success opens a dialog message:

image

@paulo-ocean
Copy link
Contributor

hi @jamiehewitt15 can we check the conflicts ? thanks

@jamiehewitt15 jamiehewitt15 self-assigned this Aug 29, 2024
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we will need to improve on the UX..

@jamiehewitt15 jamiehewitt15 merged commit a221025 into main Aug 30, 2024
12 checks passed
@jamiehewitt15 jamiehewitt15 deleted the issue-295-dashboard-transfer-fees branch August 30, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard: allow admin to transfer collected fees
3 participants