Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix exceptions log folder missing (going to root) #61

Merged
merged 2 commits into from
Oct 20, 2023
Merged

fix exceptions log folder missing (going to root) #61

merged 2 commits into from
Oct 20, 2023

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Oct 20, 2023 •
edited
Loading

Fixes #60 .

Changes proposed in this PR:

  • exceptions.log was missing 'dirname' (should go to /logs as well)

@paulo-ocean paulo-ocean requested a review from alexcos20 October 20, 2023 08:54
@alexcos20
Copy link
Member

can you run "npm run lint:fix" please?

@paulo-ocean
Copy link
Contributor Author

can you run "npm run lint:fix" please?

done 👍

@paulo-ocean paulo-ocean merged commit e2aa6ea into develop Oct 20, 2023
4 checks passed
@alexcos20 alexcos20 deleted the fix-exceptions-log-folder branch October 20, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcos20 alexcos20 alexcos20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulo-ocean @alexcos20