Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding class for SQLite and crud functions #597

Merged
merged 10 commits into from
Aug 14, 2024
Merged

Adding class for SQLite and crud functions #597

merged 10 commits into from
Aug 14, 2024

Conversation

jamiehewitt15
Copy link
Member

@jamiehewitt15 jamiehewitt15 commented Aug 7, 2024 •
edited
Loading

Fixes #597

Changes proposed in this PR:

  • Adding SQLite for the nonce database. Only runs when a valid Typesense URL is not provided.
  • Testing the nonce database when no Typesense URL is provided.

@bogdanfazakas
Copy link
Member

Hi @jamiehewitt15 are like going to create smaller PR's to integrate SQLite in the nodes flow ?

@jamiehewitt15 jamiehewitt15 marked this pull request as draft August 8, 2024 12:48
@jamiehewitt15
Copy link
Member Author

Hi @jamiehewitt15 are like going to create smaller PR's to integrate SQLite in the nodes flow ?

I'm still testing it locally, but I thought I would add it to this PR. I have marked it as draft for now.

@bogdanfazakas
Copy link
Member

Hi @jamiehewitt15 are like going to create smaller PR's to integrate SQLite in the nodes flow ?

I'm still testing it locally, but I thought I would add it to this PR. I have marked it as draft for now.

great thanks 👍

@jamiehewitt15 jamiehewitt15 marked this pull request as ready for review August 12, 2024 20:14
mariacarmina
mariacarmina reviewed Aug 13, 2024
View reviewed changes
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a suggestion from my side.

src/components/database/index.ts Show resolved Hide resolved
mariacarmina
mariacarmina approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jamiehewitt15 jamiehewitt15 self-assigned this Aug 13, 2024
@jamiehewitt15 jamiehewitt15 merged commit 9319b6f into develop Aug 14, 2024
8 checks passed
@jamiehewitt15 jamiehewitt15 deleted the issue-524-sqlite branch August 14, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcos20 alexcos20 alexcos20 approved these changes

@mariacarmina mariacarmina mariacarmina approved these changes

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

@paulo-ocean paulo-ocean Awaiting requested review from paulo-ocean paulo-ocean is a code owner

Assignees

@jamiehewitt15 jamiehewitt15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamiehewitt15 @bogdanfazakas @alexcos20 @mariacarmina