Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use only git tracked files for computing code hash #595

Merged
merged 4 commits into from
Aug 14, 2024
Merged

use only git tracked files for computing code hash #595

merged 4 commits into from
Aug 14, 2024

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Aug 6, 2024 •
edited
Loading

Fixes #589

Changes proposed in this PR:

  • change a bit code hash logic, use only tracked git files to compute hash (ignore other files present)
  • default to previous implementation if issues with git commands
  • add unit test
  • fix some unrelated test that fails randomly

@paulo-ocean paulo-ocean self-assigned this Aug 6, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review August 6, 2024 16:58
@alexcos20 alexcos20 merged commit f3dd129 into develop Aug 14, 2024
8 checks passed
@alexcos20 alexcos20 deleted the issue-589-code-hash-git branch August 14, 2024 13:15
@paulo-ocean paulo-ocean mentioned this pull request Aug 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@alexcos20 alexcos20 alexcos20 approved these changes

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulo-ocean @alexcos20 @bogdanfazakas