Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure we always start indexing on ganache, even if no block info available (from block 0)… #594

Merged
merged 1 commit into from
Aug 6, 2024
Merged

make sure we always start indexing on ganache, even if no block info available (from block 0)… #594

merged 1 commit into from
Aug 6, 2024

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Aug 5, 2024 •
edited
Loading

…, from block zero

Fixes #493

Changes proposed in this PR:

  • even if we can't get block info, we still start from block 0 (local network only)
  • helper utils fn to check for undefined/null same time

@paulo-ocean paulo-ocean marked this pull request as ready for review August 5, 2024 17:28
bogdanfazakas
bogdanfazakas approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jamiehewitt15
jamiehewitt15 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulo-ocean paulo-ocean merged commit 0c03f69 into develop Aug 6, 2024
8 checks passed
@paulo-ocean paulo-ocean deleted the issue-493-start-block-ganache branch August 6, 2024 09:44
@paulo-ocean paulo-ocean mentioned this pull request Aug 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulo-ocean @bogdanfazakas @jamiehewitt15