Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more try catch #586

Merged
merged 1 commit into from
Aug 1, 2024
Merged

more try catch #586

merged 1 commit into from
Aug 1, 2024

Conversation

paulo-ocean
Copy link
Contributor

Fixes # .

Changes proposed in this PR:

  • outer try/catch on directCommand, just in case
  • improve some logs

@paulo-ocean paulo-ocean marked this pull request as ready for review August 1, 2024 15:15
@paulo-ocean paulo-ocean self-assigned this Aug 1, 2024
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@paulo-ocean paulo-ocean merged commit 40b86b8 into develop Aug 1, 2024
8 checks passed
@paulo-ocean paulo-ocean deleted the improve-try-catch branch August 1, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants