Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging all errors #583

Merged
merged 7 commits into from
Aug 12, 2024
Merged

Logging all errors #583

merged 7 commits into from
Aug 12, 2024

Conversation

jamiehewitt15
Copy link
Member

@jamiehewitt15 jamiehewitt15 commented Aug 1, 2024 •
edited
Loading

Fixes # .

Changes proposed in this PR:

  • We have a few try/catch statements where we don't log the error. This is not very helpful for debugging.
  • Adding the additional logs gives a clearer picture of why the node might have failed in these situations.

@jamiehewitt15 jamiehewitt15 self-assigned this Aug 1, 2024
@jamiehewitt15 jamiehewitt15 marked this pull request as ready for review August 6, 2024 10:23
paulo-ocean
paulo-ocean approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bogdanfazakas
bogdanfazakas approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jamiehewitt15 jamiehewitt15 merged commit 77ff139 into develop Aug 12, 2024
8 checks passed
@jamiehewitt15 jamiehewitt15 deleted the improve-error-logs branch August 12, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees

@jamiehewitt15 jamiehewitt15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamiehewitt15 @bogdanfazakas @paulo-ocean