Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix possible response with connection closed #577

Merged
merged 2 commits into from
Aug 1, 2024
Merged

fix possible response with connection closed #577

merged 2 commits into from
Aug 1, 2024

Conversation

paulo-ocean
Copy link
Contributor

Fixes #576

Changes proposed in this PR:

  • additional try/catch on directCommand endpoint.
  • check for connection close events
  • avoid write to a closed socket

@paulo-ocean paulo-ocean self-assigned this Aug 1, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review August 1, 2024 10:34
jamiehewitt15
jamiehewitt15 approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

mariacarmina
mariacarmina approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulo-ocean paulo-ocean merged commit b45d819 into develop Aug 1, 2024
6 checks passed
@paulo-ocean paulo-ocean deleted the issue-576-connection-close branch August 1, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariacarmina mariacarmina mariacarmina approved these changes

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulo-ocean @jamiehewitt15 @mariacarmina