Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix possible crash, add try catch when cannot process task and send response #572

Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix possible crash, add try catch when cannot process task and send response #572

merged 1 commit into from
Jul 31, 2024

Conversation

paulo-ocean
Copy link
Contributor

Fixes # .

Changes proposed in this PR:

  • add try/catch when trying to process invalid/missing data and send response

@paulo-ocean paulo-ocean self-assigned this Jul 31, 2024
@paulo-ocean paulo-ocean changed the title fix possible crach, add try catch fix possible crash, add try catch when cannot process task and send response Jul 31, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review July 31, 2024 14:20
alexcos20
alexcos20 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulo-ocean paulo-ocean merged commit 2595e0d into develop Jul 31, 2024
6 checks passed
@paulo-ocean paulo-ocean deleted the fix-crash-task-undefined branch July 31, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@alexcos20 alexcos20 alexcos20 approved these changes

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulo-ocean @alexcos20 @bogdanfazakas