Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve peer discovery time, avoid connect again on connection handler #568

Merged
merged 5 commits into from
Aug 14, 2024
Merged

improve peer discovery time, avoid connect again on connection handler #568

merged 5 commits into from
Aug 14, 2024

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Jul 30, 2024 •
edited
Loading

Fixes #

Changes proposed in this PR:
Try to decrease the P2P connections overload by fine tuning some settings:

  • increase P2P connection default discovery interval (from 1 sec to 3 secs)
  • provide auto-dial configurable interval (default is 5 seconds)
  • avoid extra pubsub connection on peer connection handler/listener

@paulo-ocean paulo-ocean changed the title improve peer discovery time, avoid connect on connection improve peer discovery time, avoid connect again on connection handler Jul 30, 2024
@paulo-ocean paulo-ocean self-assigned this Jul 30, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review August 6, 2024 17:05
bogdanfazakas
bogdanfazakas approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jamiehewitt15
jamiehewitt15 approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@alexcos20 alexcos20 merged commit 4febd84 into develop Aug 14, 2024
8 checks passed
@alexcos20 alexcos20 deleted the issue-optimize-cpu branch August 14, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulo-ocean @bogdanfazakas @jamiehewitt15 @alexcos20