Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 565 optimize get status #566

Merged
merged 10 commits into from
Jul 31, 2024
Merged

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Jul 29, 2024

Fixes #565 #567

Changes proposed in this PR:

  • cache some data on getStatus()... Only fetch new data that actually changes between requests
  • fix small issue on P2P handleProtocolCommands() if task/command is undefined (can crash node)

@paulo-ocean paulo-ocean marked this pull request as ready for review July 29, 2024 13:06
@paulo-ocean paulo-ocean self-assigned this Jul 29, 2024
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulo-ocean paulo-ocean merged commit f4bfb44 into develop Jul 31, 2024
6 checks passed
@paulo-ocean paulo-ocean deleted the issue-565-optimize-get-status branch July 31, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants