Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add naive detection of public ip address #554

Merged
merged 2 commits into from
Jul 16, 2024
Merged

add naive detection of public ip address #554

merged 2 commits into from
Jul 16, 2024

Conversation

alexcos20
Copy link
Member

@alexcos20 alexcos20 commented Jul 15, 2024 •
edited
Loading

Changes proposed in this PR:

  • detects addresses used by node
  • for each ip family, try to detect public ip address
  • if found, add it to transports as observedAddress, other nodes will have to confirm it

jamiehewitt15
jamiehewitt15 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It's definitely better than nothing

paulo-ocean
paulo-ocean approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexcos20 alexcos20 merged commit e144cfa into develop Jul 16, 2024
6 checks passed
@alexcos20 alexcos20 deleted the feature/public_address_naive_detection branch July 16, 2024 17:13
@mihaisc mihaisc mentioned this pull request Jul 22, 2024
Closed
@paulo-ocean paulo-ocean mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexcos20 @jamiehewitt15 @paulo-ocean