Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes on logging transports (.env var based locations) #553

Merged
merged 57 commits into from
Jul 29, 2024
Merged

Changes on logging transports (.env var based locations) #553

merged 57 commits into from
Jul 29, 2024

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Jul 15, 2024 •
edited
Loading

Fixes #523 .

Changes proposed in this PR:

  • use .env vars to decide where to log (file, console, db)
  • fix tests and core log logic

@paulo-ocean paulo-ocean changed the title change son logging transports change on logging transports (env var based locations) Jul 15, 2024
@paulo-ocean paulo-ocean changed the title change on logging transports (env var based locations) Changes on logging transports (.env var based locations) Jul 15, 2024
@paulo-ocean paulo-ocean self-assigned this Jul 15, 2024
paulo-ocean added 26 commits July 15, 2024 17:20
@paulo-ocean
Merge branch 'develop' into issue-523-logs-location
970c526
@paulo-ocean
some debug
c7f6011
@paulo-ocean
more debug
406cf32
@paulo-ocean
updates of constants, plus docs
f109cdd
@paulo-ocean
fix test? number conversion
d50c979
@paulo-ocean
more debug on test
2487e0b
@paulo-ocean
more debug on test
d994ed8
@paulo-ocean
more debug on test
841c216
@paulo-ocean
more debug
ca8ce55
@paulo-ocean
more debugging
181000c
@paulo-ocean
remove garbage logs from typsense normal stuff
d1b655f
@paulo-ocean
fix condition for ignore
ae24742
@paulo-ocean
clean filter, avoid useless msgs
4bdf70a
@paulo-ocean
deafult typesense logger, error, only
0437247
@paulo-ocean
update tests
da16340
@paulo-ocean
update tests
d784853
@paulo-ocean
check module name as well
1eae945
@paulo-ocean
check module name as well
f79dc5e
@paulo-ocean
check module name as well
9b165c2
@paulo-ocean
check module name as well
8f196ad
@paulo-ocean
check module name as well
a2edc6a
@paulo-ocean
add more logs in 30 days interval check
9322716
@paulo-ocean
more debug
d27257a
@paulo-ocean
fix tests logs
f2d6672
@paulo-ocean
Merge branch 'develop' into issue-523-logs-location
78a26d3
@paulo-ocean
more log changes, check log level for decide to log or not
7edee9b
jamiehewitt15
jamiehewitt15 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We could probably also benefit from having a section in the docs about the logs, I'll handle that in the documentation PR

@paulo-ocean
Copy link
Contributor Author

Looks good to me. We could probably also benefit from having a section in the docs about the logs, I'll handle that in the documentation PR

thanks, btw, just did a small update on the env.md

bogdanfazakas
bogdanfazakas approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulo-ocean paulo-ocean merged commit fc7320e into develop Jul 29, 2024
6 checks passed
@paulo-ocean paulo-ocean deleted the issue-523-logs-location branch July 29, 2024 13:16
@paulo-ocean paulo-ocean mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulo-ocean @bogdanfazakas @jamiehewitt15