Check if ddo state is active before executing node's commands. #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariacarmina
requested review from
alexcos20,
bogdanfazakas,
jamiehewitt15 and
paulo-ocean
as code owners
jamiehewitt15
requested changes
Jul 10, 2024
There was a problem hiding this comment.
This PR doesn't follow the state specification. You are treating every non-zero state the same when they are actually meant to be different. For example: ordering the asset is allowed for state 5.
You need to refer to the state specification in the docs: https://docs.oceanprotocol.com/developers/ddo-specification#state
paulo-ocean
requested changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #540 .
Changes proposed in this PR: