Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass the headers back to client request #522

Merged
merged 3 commits into from
Jul 5, 2024
Merged

pass the headers back to client request #522

merged 3 commits into from
Jul 5, 2024

Conversation

paulo-ocean
Copy link
Contributor

Fixes #521

Changes proposed in this PR:

  • pass the headers from the getResults (useful for download the proper attached file, with proper name)

@paulo-ocean paulo-ocean self-assigned this Jul 4, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review July 5, 2024 09:00
@alexcos20 alexcos20 linked an issue Jul 5, 2024 that may be closed by this pull request
getResult (get compute job result) is not passing the 'content-disposition' headers #521
Closed
jamiehewitt15
jamiehewitt15 approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulo-ocean paulo-ocean merged commit 6ea49cd into develop Jul 5, 2024
6 checks passed
@paulo-ocean paulo-ocean deleted the issue-521-headers-getresults branch July 5, 2024 13:29
@paulo-ocean paulo-ocean mentioned this pull request Jul 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@alexcos20 alexcos20 alexcos20 approved these changes

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getResult (get compute job result) is not passing the 'content-disposition' headers
3 participants
@paulo-ocean @alexcos20 @jamiehewitt15