Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 506 agreementid stop #508

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Issue 506 agreementid stop #508

merged 6 commits into from
Aug 14, 2024

Conversation

paulo-ocean
Copy link
Contributor

Fixes #506 .

Changes proposed in this PR:

  • Add support for agreementId

@paulo-ocean paulo-ocean changed the base branch from main to develop June 26, 2024 07:39
@paulo-ocean paulo-ocean self-assigned this Jun 26, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review June 26, 2024 09:37
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexcos20 alexcos20 merged commit 3887055 into develop Aug 14, 2024
8 checks passed
@alexcos20 alexcos20 deleted the issue-506-agreementid-stop branch August 14, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stop compute command, not dealing with optional agreementId
4 participants