Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 501 - C2D getJobStatus - did vs documentId vs agreementId #502

Merged
merged 22 commits into from
Sep 16, 2024

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Jun 19, 2024

Fixes #501

Changes proposed in this PR:

  • support for agreementId field

@paulo-ocean paulo-ocean changed the title Issue 501 document Issue 501 - C2D getJobStatus - did vs documentId vs agreementId Jun 19, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review June 26, 2024 09:37
@paulo-ocean paulo-ocean self-assigned this Jun 28, 2024
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment on my side. otherwise it's fine.

src/components/httpRoutes/compute.ts Show resolved Hide resolved
@alexcos20 alexcos20 changed the base branch from develop to main August 14, 2024 19:00
@paulo-ocean paulo-ocean merged commit 181a3e1 into main Sep 16, 2024
12 checks passed
@paulo-ocean paulo-ocean deleted the issue-501-documentId branch September 16, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getComputeStatus "did" param mismatch "documentId" from SDK
4 participants