Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide raw data on logging, when checking command data #480

Merged
merged 5 commits into from
May 28, 2024
Merged

hide raw data on logging, when checking command data #480

merged 5 commits into from
May 28, 2024

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented May 28, 2024 •
edited
Loading

Fixes #472 .

Changes proposed in this PR:

  • hide rawData on ENCRYPT_FILE command from logging (can be a huge buffer)
  • deep copy with structuredClone

@paulo-ocean paulo-ocean self-assigned this May 28, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review May 28, 2024 14:49
@paulo-ocean paulo-ocean merged commit 98fdc42 into develop May 28, 2024
5 checks passed
@paulo-ocean paulo-ocean deleted the issue-472-clean-logs-raw-data branch May 28, 2024 15:08
@paulo-ocean paulo-ocean mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@alexcos20 alexcos20 alexcos20 approved these changes

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulo-ocean @alexcos20 @bogdanfazakas