Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper handle of boolean envs #479

Merged
merged 4 commits into from
May 29, 2024
Merged

Conversation

alexcos20
Copy link
Member

Changes proposed in this PR:

  • add & use getBoolEnvValue function in config

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

src/utils/config.ts Outdated Show resolved Hide resolved
@alexcos20 alexcos20 requested a review from paulo-ocean May 29, 2024 08:32
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexcos20 alexcos20 merged commit 6287c21 into develop May 29, 2024
5 checks passed
@alexcos20 alexcos20 deleted the feature/proper_handle_of_bool_envs branch May 29, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants