Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Env docs #467

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Updating Env docs #467

merged 5 commits into from
Jun 5, 2024

Conversation

jamiehewitt15
Copy link
Member

Fixes #462

Changes proposed in this PR:

  • Updating Env docs
  • Removing second env file

@jamiehewitt15 jamiehewitt15 requested a review from alexcos20 as a code owner May 23, 2024 13:00
@jamiehewitt15 jamiehewitt15 changed the base branch from main to develop May 23, 2024 13:00
@bogdanfazakas
Copy link
Member

Based on our channel discussion think we need to update the env docs using the generally preferred style.

@bogdanfazakas
Copy link
Member

@jamiehewitt15 since you also removed the 2'nd env file from docs, please update the reference from this topic as well https://github.com/oceanprotocol/ocean-node/tree/env-docs?tab=readme-ov-file#environment-variables
thanks

Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jamiehewitt15 jamiehewitt15 merged commit a35eafd into develop Jun 5, 2024
5 checks passed
@jamiehewitt15 jamiehewitt15 deleted the env-docs branch June 5, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document env vars
3 participants