Remove hardcoded code for root endpoint. #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariacarmina
requested review from
alexcos20,
bogdanfazakas,
jamiehewitt15 and
paulo-ocean
as code owners
|
Response from root endpoint now: 
|
mariacarmina
changed the title
paulo-ocean
reviewed
May 21, 2024
|
This is good, but it would be even better if the route endpoints are also dynamically generated, rather than hardcoded in a json. As you've seen that list tends to be ignored and it will probably become out of date again soon. It would be nice if we don't have to maintain it. |
I agree, this will get outdated again probably, but probably better do it on another PR. i can create another PR for this |
jamiehewitt15
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #435 .
Changes proposed in this PR:
/