Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logs download: adding query parameters #365

Merged
merged 13 commits into from
May 9, 2024

Conversation

tom1145
Copy link
Collaborator

@tom1145 tom1145 commented Mar 20, 2024

Fixes #320.

Changes proposed in this PR:

  • adds filter inputs for downloading the logs

@tom1145 tom1145 self-assigned this Mar 20, 2024
@tom1145 tom1145 linked an issue Mar 20, 2024 that may be closed by this pull request
@jamiehewitt15
Copy link
Member

Can you pull the latest changes from origin develop to fix the issue with the test?

@tom1145
Copy link
Collaborator Author

tom1145 commented Mar 21, 2024

Can you pull the latest changes from origin develop to fix the issue with the test?

I made a sync on both of them now. Thanks!

Base automatically changed from feat/65-retrieve-and-display-connected-nodes to develop April 4, 2024 16:12
@jamiehewitt15 jamiehewitt15 changed the title feat: improve download Improve logs download: adding query parameters Apr 25, 2024
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some changes to make sure this works with the new authentication that's required to download the logs + updated the styling. Now using MUI as a simple way to improve the UX.

image

@jamiehewitt15 jamiehewitt15 self-assigned this May 7, 2024
@jamiehewitt15
Copy link
Member

@bogdanfazakas @paulo-ocean @mariacarmina Can you have a look at this PR when you have time? Thank you

Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bogdanfazakas
Copy link
Member

Hey @jamiehewitt15 is download logs functionality working on your end? i always end up with a 403 with invalid signature error.
Screenshot 2024-05-08 at 08 22 06
Screenshot 2024-05-08 at 08 23 25

@jamiehewitt15
Copy link
Member

Thanks for testing this @bogdanfazakas. The expiry timestamp in your request is 1713301201844 = Tuesday, 16 April 2024 so it's already expired. It should ask you for another signature in this situation, so I'll look into why that's not happening.

@jamiehewitt15
Copy link
Member

@bogdanfazakas I've introduced some improvements that should solve your issue:

  1. signature and expiry timestamp are only stored in local storage if they are still valid
  2. they are only used, when retrieved from local storage if they are still valid
  3. if the signature is from a different account to the one currently connected, they are removed.
  4. Better error responses on the auth function.

Could you test it again from the same browser? It should recognise that your expiryTimestamp is in the past and show you the unlock button so that you sign another message.

@bogdanfazakas
Copy link
Member

@bogdanfazakas I've introduced some improvements that should solve your issue:

  1. signature and expiry timestamp are only stored in local storage if they are still valid
  2. they are only used, when retrieved from local storage if they are still valid
  3. if the signature is from a different account to the one currently connected, they are removed.
  4. Better error responses on the auth function.

Could you test it again from the same browser? It should recognise that your expiryTimestamp is in the past and show you the unlock button so that you sign another message.

Nice fix, immediately asked me to unlock the admin features with that came the sign again operation, then download logs worked fine. 👍

@jamiehewitt15
Copy link
Member

Nice fix, immediately asked me to unlock the admin features with that came the sign again operation, then download logs worked fine. 👍

Excellent, thanks for testing

@jamiehewitt15 jamiehewitt15 merged commit 73d615d into develop May 9, 2024
6 checks passed
@jamiehewitt15 jamiehewitt15 deleted the feat/320-improve-download branch May 9, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve "Download Logs" in dashboard
4 participants