-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logs download: adding query parameters #365
Conversation
Can you pull the latest changes from origin develop to fix the issue with the test? |
…/320-improve-download
I made a sync on both of them now. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…at/320-improve-download
…at/320-improve-download
@bogdanfazakas @paulo-ocean @mariacarmina Can you have a look at this PR when you have time? Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…at/320-improve-download
Hey @jamiehewitt15 is download logs functionality working on your end? i always end up with a 403 with invalid signature error. |
…at/320-improve-download
Thanks for testing this @bogdanfazakas. The expiry timestamp in your request is |
…o help troubleshooting
…torage if it is valid
…reamlining signing process
@bogdanfazakas I've introduced some improvements that should solve your issue:
Could you test it again from the same browser? It should recognise that your expiryTimestamp is in the past and show you the unlock button so that you sign another message. |
Nice fix, immediately asked me to unlock the admin features with that came the sign again operation, then download logs worked fine. 👍 |
Excellent, thanks for testing |
Fixes #320.
Changes proposed in this PR: