Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/65 retrieve and display connected nodes #339

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Feat/65 retrieve and display connected nodes #339

merged 4 commits into from
Apr 4, 2024

Conversation

tom1145
Copy link
Collaborator

@tom1145 tom1145 commented Mar 14, 2024

Fixes #65.

Changes proposed in this PR:

  • list all the connected nodes.

@tom1145 tom1145 self-assigned this Mar 14, 2024
@tom1145 tom1145 requested a review from alexcos20 as a code owner March 14, 2024 08:02
@tom1145 tom1145 changed the base branch from main to develop March 14, 2024 08:02
@jamiehewitt15
Copy link
Member

Can you move all of this into a new component in a separate file and then import it, dashboard/src/components/Dashboard/index.tsx is already too big. We should also move ConnectionDetails, Indexer and AdminAccounts into separate files but you don't need to do that in this PR.

paulo-ocean
paulo-ocean approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. maybe in the future we could listen for events when another peer joins, so we don't need to reload the page, but not for now of course

@paulo-ocean
Copy link
Contributor

i think we can merge this.. its been approved last week already, i'm merging it

@paulo-ocean paulo-ocean merged commit 7d7c5a6 into develop Apr 4, 2024
6 checks passed
@paulo-ocean paulo-ocean deleted the feat/65-retrieve-and-display-connected-nodes branch April 4, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees

@tom1145 tom1145

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retrieve and display connected nodes
3 participants
@tom1145 @jamiehewitt15 @paulo-ocean