Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix write after response end #337

Merged
merged 5 commits into from
Mar 20, 2024
Merged

fix write after response end #337

merged 5 commits into from
Mar 20, 2024

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Mar 12, 2024 •
edited
Loading

Fixes #335 .

Changes proposed in this PR:

  • remove unnecessary write() call . (we already use pipe() to handle the reponses)

@paulo-ocean paulo-ocean self-assigned this Mar 13, 2024
jamiehewitt15
jamiehewitt15 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it solves the problem.

@paulo-ocean paulo-ocean merged commit be44ae6 into develop Mar 20, 2024
6 checks passed
@paulo-ocean paulo-ocean deleted the issue-335-crash-on-status-not-200 branch March 20, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulo-ocean @bogdanfazakas @jamiehewitt15