Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth admin route #319

Merged
merged 37 commits into from
Mar 11, 2024
Merged

Auth admin route #319

merged 37 commits into from
Mar 11, 2024

Conversation

mariacarmina
Copy link
Member

@mariacarmina mariacarmina commented Mar 5, 2024 •
edited
Loading

Fixes #296 .

Changes proposed in this PR:

  • add admin route for auth
  • add test
  • added handler for testing

@mariacarmina mariacarmina self-assigned this Mar 5, 2024
@mariacarmina mariacarmina marked this pull request as ready for review March 5, 2024 16:49
@jamiehewitt15
Copy link
Member

Either in this PR or another one, we also need a simple endpoint that will return the array of admin addresses.

@mariacarmina
Copy link
Member Author

Either in this PR or another one, we also need a simple endpoint that will return the array of admin addresses.

I'll do it in this PR.

@mariacarmina
Copy link
Member Author

Postman response for directCommand calling status handler:
Screenshot 2024-03-07 at 15 59 50

jamiehewitt15
jamiehewitt15 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested locally and it's working well

bogdanfazakas
bogdanfazakas approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

mariacarmina
mariacarmina commented Mar 8, 2024
View reviewed changes
src/utils/auth.ts Outdated Show resolved Hide resolved
paulo-ocean
paulo-ocean reviewed Mar 8, 2024
View reviewed changes
src/utils/config.ts Outdated Show resolved Hide resolved
@mariacarmina
Copy link
Member Author

Fixed the comments and tested again on postman, seems to work fine:

Screenshot 2024-03-11 at 13 24 30 I'll merge it, thanks for reviews

@mariacarmina mariacarmina merged commit 6bce1a2 into develop Mar 11, 2024
6 checks passed
@mariacarmina mariacarmina deleted the auth-admin-route branch March 11, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

Assignees

@mariacarmina mariacarmina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mariacarmina @jamiehewitt15 @bogdanfazakas @paulo-ocean