-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve integration tests #267
Conversation
…/tests for something not required
Tried running it a couple of times locally and both times it failed on the same test. Is this something to do with the timeout? Or have I done something wrong in the setup?
|
Not sure, it does work for me.. but i also know that our tests don't usually work locally. In fact i changed a few that always fail locally and rely only on CI stuff/env. i can have a look later, maybe i can have a clue on the why it fails for you locally |
Could be the env values that I'm using, maybe something is missing. This is what I'm using at the moment:
|
gonna try with those... and let you know. i think maybe DB related, or something that is on CI and its not part of the .env.test file , but again, no branch at the moment has tests running locally (for a long time) |
What about this branch, is it working for you every time? I ran it again but got a different error this time, I wonder if it might just be something to do with the timeout that's causing some random errors with the requests.
|
Its not timeout related, i mean, you could increase the timeout on the test as much as you can, it will still timeout locally... the issue is env/db related for sure.. works fine on CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big improvement in running the integration tests in the CI. Let's work on fixing them when running locally in a separate issue: #280
Fixes #250 .
Changes proposed in this PR: