-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 205 ddo handling #239
Conversation
…sue-205-DDO-handling
…sue-205-DDO-handling
…an-node into issue-205-DDO-handling
…sue-205-DDO-handling
…sue-205-DDO-handling
…e creating a new on in a different collection
…sue-205-DDO-handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question, looking at the code, I could not find the validation result when saving the DDO for metadata events (in the processor.ts). I think this issue should also include this part as well, not only at the database level, but correct me if I am wrong.
The focus of this issue is making sure that we're using the right schema and collection when entering or retrieving data from the database. When the metadata is saved into a collection from |
Currently blocked by this issue as the short DDO can't pass the validation: #256 Could potentially implement a quick fix to bypass that issue:
|
Tests are passing now as I implemented a workaround: avoiding doing any validation on the short DDO until the validation function has been updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes #205
Changes proposed in this PR: