Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 227 get environments #238

Merged
merged 21 commits into from
Jan 29, 2024
Merged

Issue 227 get environments #238

merged 21 commits into from
Jan 29, 2024

Conversation

jamiehewitt15
Copy link
Member

@jamiehewitt15 jamiehewitt15 commented Jan 23, 2024 •
edited
Loading

Fixes #227

Changes proposed in this PR:

  • Creating the GetEnvironments P2P Handler
  • Creating the HTTP API endpoint for /api/services/computeEnvironments
  • Adding integrations test for the GetEnvironments P2P Handler
  • Fixing bug with getC2DClusterEnvironment()

@jamiehewitt15 jamiehewitt15 changed the base branch from main to develop January 23, 2024 13:22
@jamiehewitt15 jamiehewitt15 self-assigned this Jan 24, 2024
@alexcos20
Copy link
Member

this depends on #241

@jamiehewitt15 jamiehewitt15 marked this pull request as ready for review January 25, 2024 13:27
paulo-ocean
paulo-ocean reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch on the bug, my bad thanks :-) 👍

paulo-ocean
paulo-ocean approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bogdanfazakas
bogdanfazakas approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jamiehewitt15 jamiehewitt15 merged commit 73afbff into develop Jan 29, 2024
6 checks passed
@jamiehewitt15 jamiehewitt15 deleted the issue-227-get-environments branch January 29, 2024 12:11
@paulo-ocean
Copy link
Contributor

just noticed the name of the command does not follow the same nomenclature of the others (they all end with "Command" suffix, IMO, its important to be consistent :-)
Just renamed that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@an7e an7e Awaiting requested review from an7e

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees

@jamiehewitt15 jamiehewitt15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C2D: Get environments
4 participants
@jamiehewitt15 @alexcos20 @paulo-ocean @bogdanfazakas