Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate shacl schemas. #210

Merged
merged 26 commits into from
Jan 18, 2024
Merged

Integrate shacl schemas. #210

merged 26 commits into from
Jan 18, 2024

Conversation

mariacarmina
Copy link
Member

@mariacarmina mariacarmina commented Jan 9, 2024

Fixes #206 .

Changes proposed in this PR:

  • added shacl schemas
  • create validation function which will be used in validateDDO command
  • created tests

@mariacarmina mariacarmina self-assigned this Jan 9, 2024
@mariacarmina mariacarmina marked this pull request as ready for review January 12, 2024 11:39
@mariacarmina
Copy link
Member Author

In this PR, @alexcos20, there is the validation function (+ tests for it) against a certain shacl schema. Let me know if I should also integrate the validateDDO command or leave the command in a separate task. And also if you have any suggestions for this current implementation, let me know.
Thanks!

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariacarmina mariacarmina merged commit 67826dc into develop Jan 18, 2024
6 checks passed
@mariacarmina mariacarmina deleted the shacl-schemas branch January 18, 2024 10:20
@mariacarmina mariacarmina mentioned this pull request Jan 22, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants