refactor ocean node, clean commands + handlers #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulo-ocean
changed the title
paulo-ocean
requested review from
alexcos20,
bogdanfazakas,
jamiehewitt15,
an7e and
mariacarmina
as code owners
an7e
reviewed
Jan 8, 2024
alexcos20
changed the title
bogdanfazakas
approved these changes
Jan 10, 2024
alexcos20
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181
Changes proposed in this PR:
Clean handlers classes + protocol commands usage, refactor OceanNode class and a little bit on the handlers
Main changes:
new class
CoreHandlersRegistry. its used to register all core handlers (easy to add more on demand). Some helper methods on the same file. Singleton instance.Ocean Node has a property of this type (
coreHandlers), which is used to get the correct handler for a givenCommand. Basically uses the Singleton above.No more switch / case.. just get the handler from the OceanNode or Singleton (see
handleDirectProtocolCommandsandhandleProtocolCommands)/utils/logging/common.js. Its easier to keep track of them and avoids issues with dependency cycling(Note: There are many files changed but in most cases it was just these "Logger" related imports)