Feature/more_p2p_tests #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alexcos20
commented
Dec 22, 2023
•
alexcos20
commented
- Move bootstrap nodes to config
- add more p2p unit tests
alexcos20
requested review from
bogdanfazakas,
jamiehewitt15,
an7e,
mariacarmina and
paulo-ocean
as code owners
paulo-ocean
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
LGTM. 👍
but i think we should consider this at some point: #138
When we run our tests locally we're in many cases overriding existing process.env properties
|
There are some conflicts here |
jamiehewitt15
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.