Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor, reduce logger instances, reuse them #178

Merged
merged 9 commits into from
Dec 21, 2023
Merged

refactor, reduce logger instances, reuse them #178

merged 9 commits into from
Dec 21, 2023

Conversation

paulo-ocean
Copy link
Contributor

Fixes #166

Changes proposed in this PR:

  • refactor, reuse logger instances when possible

@paulo-ocean paulo-ocean changed the title refactor, just one logger for all http components refactor, reduce logger instances, reuse them Dec 19, 2023
@paulo-ocean paulo-ocean marked this pull request as ready for review December 19, 2023 16:49
alexcos20
alexcos20 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulo-ocean paulo-ocean merged commit f3540be into develop Dec 21, 2023
0 of 6 checks passed
@paulo-ocean paulo-ocean deleted the feature-reduce-log-instances branch December 21, 2023 12:12
@paulo-ocean paulo-ocean mentioned this pull request Dec 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@alexcos20 alexcos20 alexcos20 approved these changes

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 is a code owner

@an7e an7e Awaiting requested review from an7e

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulo-ocean @alexcos20 @bogdanfazakas