Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate nonce test #146

Merged
merged 17 commits into from
Dec 7, 2023
Merged

Integrate nonce test #146

merged 17 commits into from
Dec 7, 2023

Conversation

mariacarmina
Copy link
Member

@mariacarmina mariacarmina commented Dec 6, 2023 •
edited
Loading

Fixes #147 .

Changes proposed in this PR:

  • fix nonce test
  • fix typesense db URL

@mariacarmina mariacarmina changed the base branch from main to develop December 6, 2023 15:00
@mariacarmina mariacarmina self-assigned this Dec 6, 2023
@mariacarmina mariacarmina marked this pull request as ready for review December 6, 2023 17:20
jamiehewitt15
jamiehewitt15 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. There are more test cases we could add on the nonce tests, like testing we get the right response when it is not found, but this is an improvement on what we currently have

@paulo-ocean
Copy link
Contributor

neither the node starts, neither the tests run anymore with the change of the DB url :-(

paulo-ocean
paulo-ocean approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt 👍

@mariacarmina mariacarmina merged commit e219bec into develop Dec 7, 2023
5 checks passed
@mariacarmina mariacarmina deleted the integrate-nonce-test branch December 7, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@an7e an7e Awaiting requested review from an7e

Assignees

@mariacarmina mariacarmina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mariacarmina @paulo-ocean @bogdanfazakas @jamiehewitt15