Skip to content

Commit

Permalink
Merge pull request #562 from oceanprotocol/issue-547-node-latest
Browse files Browse the repository at this point in the history
Fixing issues on latest version of node
  • Loading branch information
jamiehewitt15 authored Aug 1, 2024
2 parents 586cf44 + 9d3e96c commit d335681
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v2
with:
node-version: '18.20.4'
node-version: ['18.20.4', 'v20.16.0']
- name: Cache node_modules
uses: actions/cache@v2
env:
Expand All @@ -43,7 +43,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
node: ['18.20.4']
node: ['18.20.4', 'v20.16.0']

steps:
- uses: actions/checkout@v3
Expand All @@ -67,7 +67,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v2
with:
node-version: '18.20.4'
node-version: ['18.20.4', 'v20.16.0']
- name: Cache node_modules
uses: actions/cache@v2
env:
Expand Down Expand Up @@ -100,7 +100,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v2
with:
node-version: '18.20.4'
node-version: ['18.20.4', 'v20.16.0']
- name: Cache node_modules
uses: actions/cache@v2
env:
Expand Down Expand Up @@ -189,7 +189,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v2
with:
node-version: '18.20.4'
node-version: ['18.20.4', 'v20.16.0']

- name: Cache node_modules
uses: actions/cache@v2
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18.20.4
v20.16.0
4 changes: 2 additions & 2 deletions src/components/httpRoutes/requestValidator.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Request, Response } from 'express'
import { getConfiguration } from '../../utils'
import { HTTP_LOGGER } from '../../utils/logging/common'
import { getConfiguration } from '../../utils/index.js'
import { HTTP_LOGGER } from '../../utils/logging/common.js'

// TODO we should group common stuff,
// we have multiple similar validation interfaces
Expand Down

0 comments on commit d335681

Please sign in to comment.