Predictoor 5X Boost #824
Merged
Predictoor 5X Boost #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 36d46f2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 93.1% (0.1% change). View more on Code Climate. |
trentmc
requested changes
Mar 26, 2024
df_py/volume/reward_calculator.py
Outdated
Comment on lines
216
to
233
| rewards = perc_at_j * perc_at_ij * self.OCEAN_avail | ||
| apy_bound = TARGET_WPY * ocean_locked_ij | ||
| dcv_bound = DCV_OCEAN_j * perc_at_ij * multiplier | ||
|
|
||
| # check if predictoor asset and apply boost | ||
| # NOTE another asset might have the same multiplier value in the future | ||
| # Find a better way to check if the asset is a predictoor asset | ||
| if multiplier == PREDICTOOR_MULTIPLIER: | ||
| # amount of dcv boosted | ||
| boosted_dcv = min(OCEAN_boost_limit_predictoor, DCV_OCEAN_j) | ||
| # amount of dcv remaining | ||
| remaining_dcv = max(0, DCV_OCEAN_j - OCEAN_boost_limit_predictoor) | ||
| boosted_reward_bound = boosted_dcv * multiplier * 5 # 5X BOOST | ||
| remaining_reward_bound = remaining_dcv * multiplier # Remaining | ||
| dcv_bound = ( | ||
| boosted_reward_bound + remaining_reward_bound | ||
| ) * perc_at_ij | ||
|
|
There was a problem hiding this comment.
(Like mentioned above, remove all these changes.)
…anprotocol/df-py into issue822-5x-predictoor-boost
trentmc
reviewed
Mar 27, 2024
|
Please ignore the failing Coingecko tests, not related to this PR. Here's the issue for that: #825 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #822
Changes proposed in this PR: