Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OCEAN for challenge DF rewards #660

Merged
merged 12 commits into from
Jul 3, 2023

Conversation

trizin
Copy link
Contributor

@trizin trizin commented Jun 28, 2023

Fixes #658

Changes proposed in this PR:

  • Use OCEAN for challenge DF rewards

@trizin trizin linked an issue Jun 28, 2023 that may be closed by this pull request
@trizin trizin self-assigned this Jun 28, 2023
@trizin trizin requested review from calina-c and trentmc June 28, 2023 11:42
df_py/challenge/calc_rewards.py Outdated Show resolved Hide resolved
df_py/challenge/csvs.py Outdated Show resolved Hide resolved
Copy link
Contributor

@calina-c calina-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we should send rewards in USDT but this is MUCH simpler if all right with everyone.

@trizin trizin requested a review from trentmc July 1, 2023 15:16
@codeclimate
Copy link

codeclimate bot commented Jul 3, 2023

Code Climate has analyzed commit b3eac54 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.6% (0.0% change).

View more on Code Climate.

@calina-c calina-c merged commit c440b3f into main Jul 3, 2023
@calina-c calina-c deleted the issue658-use-ocean-in-challenge-df-reward-calculations branch July 3, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use OCEAN in Challenge DF reward calculations
3 participants