Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codebase has many pylint errors #810

Closed
1 of 2 tasks
trentmc opened this issue Mar 16, 2024 · 0 comments · Fixed by #811
Closed
1 of 2 tasks

Codebase has many pylint errors #810

trentmc opened this issue Mar 16, 2024 · 0 comments · Fixed by #811
Assignees
Labels
Type: Bug Something isn't working

Comments

@trentmc
Copy link
Member

trentmc commented Mar 16, 2024

Background / motivation

Codebase has many pylint errors. Somehow remote CI isn't catching it.

TODO

  • get CI to catch them, if possible. Update: it already has it, there's no obvious way to change it
  • fix the errors

Appendix: Errors

(venv) trentmc@tlm-macbook: ~/code/df-py $ pylint *
************* Module df_py.util.http_provider
df_py/util/http_provider.py:21:47: E1134: Non-mapping value self.get_request_kwargs() is used in a mapping context (not-a-mapping)
************* Module df_py.util.dftool_module
df_py/util/dftool_module.py:1075:14: E1120: No value for argument 'self' in unbound method call (no-value-for-parameter)
************* Module df_py.util.request
df_py/util/request.py:21:17: I1101: Module 'lru' has no 'LRU' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member)
************* Module df_py.util.oceantestutil
df_py/util/oceantestutil.py:251:11: E1120: No value for argument 'self' in unbound method call (no-value-for-parameter)
df_py/util/oceantestutil.py:256:8: E1120: No value for argument 'self' in unbound method call (no-value-for-parameter)
************* Module df_py.util.oceanutil
df_py/util/oceanutil.py:359:14: E1120: No value for argument 'values' in unbound method call (no-value-for-parameter)
************* Module df_py
df_py.egg-info/__init__.py:1:0: F0010: error while code parsing: Unable to load file df_py.egg-info/__init__.py:
[Errno 2] No such file or directory: 'df_py.egg-info/__init__.py' (parse-error)
@trentmc trentmc added the Type: Bug Something isn't working label Mar 16, 2024
@trentmc trentmc self-assigned this Mar 16, 2024
trentmc added a commit that referenced this issue Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant