Add txId in payload for RBAC check for asset indexing

[mariacarmina]

Description

Add txId in payload for RBAC check for asset indexing

Is this PR related with an open issue?

Related to Issue #1065

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• Follows the code style of this project.
• Tests Cover Changes
• Documentation

[alexcos20]

it should be

 payload = {
            "eventType": event_type,
            "component": "metadatacache",
            "txid": tx_id,
            "credentials": {"type": "address", "value": address},
        }

[mariacarmina]

Thank you! That should be it.

[soonhuat]

should aquarius also pass ddo as part of the rbac request?
so rbac can check the decrypted transaction sender vs ddo.nft.owner, or other additional checking

[mariacarmina]

I can add the DDO inside the payload for additional RBAC permission checking. What do you think @alexcos20?

[alexcos20]

@soonhuat - can you check this?

[krisliew]

@alexcos20 Perhaps this will be good? rbac can check the nft owner using the address vs txid sender

    def check_permission_rbac(event_type, address, tx_id, asset):
        try:
            chain_id = asset["chainId"]
            nftAddress = asset["nftAddress"]
        except KeyError:
            return False

        payload = {
            "eventType": event_type,
            "component": "metadatacache",
            "credentials": {"type": "address", "value": address},
            "txid": tx_id,
            "asset": { "chainId": asset["chainId"], "nftAddress": asset["nftAddress"]}
        }

[codeclimate]

Code Climate has analyzed commit e2fe315 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 84.3%.

View more on Code Climate.

[alexcos20]

lgtm.

@soonhuat - can you test it please and let us know if it's in line with your expectation

[krisliew]

LGTM 💯