Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Makefile #45

wants to merge 2 commits into from

Conversation

bbusse
Copy link

@bbusse bbusse commented Apr 6, 2023

This PR adds a Makefile with an install target for easy installation.
The second commit adds missing whitespace to a log message

@occivink
Copy link
Owner

occivink commented Apr 8, 2023

I like the idea, I just don't think we should do the printf $(input_conf) >> ${HOME}/.config/mpv/input.conf since that's not idempotent.

@bbusse
Copy link
Author

bbusse commented Apr 8, 2023

How about a second target 'install-keybindings'? This way the user has full control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants