Add support of 4.09+ multi lines errors in problem matcher #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works well for me. |
mnxn
approved these changes
May 24, 2020
|
I can't reproduce the error of the CI. Not sure why it happens. |
|
I restarted the workflows, lets see if it works. The error is |
|
It would be nice to somehow to unit test stuff like this. @mnxn do you know if it's possible? |
Unfortunately I'm not familiar with a way to do that. |
Since ocaml 4.09, when an error covers multiple lines, the message emitted by the compiler looks like this: File "robustmatch.ml", lines 33-37, characters 6-23: Warning 8: this pattern-matching is not exhaustive. Here is an example of a case that is not matched: (AB, MAB, A) This commit detects the presence of an eventual end line. Support of previous version of the compiler or single line errors is preserved.
rgrinberg
force-pushed
the
prob-matcher-409
branch
from
d7aa56d to
ba84c68
Compare
|
Thank you for your contribution |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ocaml 4.09, when an error covers multiple lines, the message
emitted by the compiler looks like this:
This commit detects the presence of an eventual end line. Support of
previous version of the compiler or single line errors is preserved.