Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize OpamString.split #6210

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate commented Sep 25, 2024

this cuts the time spent on parsing pacman -Si significantly down

Commit by @c-cube split from #5757
Queued on #6212

@kit-ty-kate
Copy link
Member Author

After trying a couple of things, it looks like opam show dune shows the significant performance improvement (25% on my local Fedora), however Debian (the system used for benchmark) shows less improvement (6 or 7%). I'll add a benchmark nonetheless and see if it can be reproduced in a better controlled environment

@kit-ty-kate kit-ty-kate added the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Sep 25, 2024
kit-ty-kate and others added 3 commits September 25, 2024 21:14
this cuts the time spent on parsing `pacman -Si` significantly down
@rjbou rjbou self-requested a review September 30, 2024 12:27
@kit-ty-kate kit-ty-kate marked this pull request as draft September 30, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AREA: PERFORMANCE PR: QUEUED Pending pull request, waiting for other work to be merged or closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants