depext: Add Altlinux family support #6207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using rpm for a package manager and apt-rpm (fork of the apt fron debian wuth RPM support) for the repository manager.
kit-ty-kate
reviewed
Sep 23, 2024
There was a problem hiding this comment.
Thanks for this PR.
This change looks reasonable modulo the one suggestion.
If you have some spare time, would you be able to add altlinux to our testsuite? (see the files .github/workflows/depexts.yml and .github/scripts/depexts/generate-actions.sh) It should just be a case of either merging the debian and altlinux case or copy-pasting. Altlinux is available as alt on Docker Hub.
If you don't have time we'll do it at some point in the future
| @@ -1142,6 +1146,7 @@ let update ?(env=OpamVariable.Map.empty) config = | |||
| let cmd = | |||
| match family with | |||
| | Alpine -> Some (`AsAdmin "apk", ["update"]) | |||
| | Altlinux -> Some (`AsAdmin "apt-get", ["update"]) | |||
There was a problem hiding this comment.
This can be merged with the Debian case below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using rpm for a package manager and apt-rpm (fork of the apt fron debian wuth RPM support) for the repository manager.