Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archetype is not compatible with OCaml 5.3 #27087

Merged
merged 3 commits into from
Dec 14, 2024

Conversation

kit-ty-kate
Copy link
Member

Expects the effect keyword to be a identifier

#=== ERROR while compiling archetype.1.5.2 ====================================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-variants.5.3.0+trunk | file:///home/opam/opam-repository
# path                 ~/.opam/5.3/.opam-switch/build/archetype.1.5.2
# command              ~/.opam/5.3/bin/dune build -p archetype -j 1 @install
# exit-code            1
# env-file             ~/.opam/log/archetype-14-c06b60.env
# output-file          ~/.opam/log/archetype-14-c06b60.out
### output ###
# (cd _build/default && .ppx/6275b1ab6a7c2471cccae8471136173f/ppx.exe --cookie 'library-name="archetype"' -o src/ast.pp.ml --impl src/ast.ml -corrected-suffix .ppx-corrected -diff-cmd - -dump-ast)
# File "src/ast.ml", line 588, characters 2-8:
# 588 |   effect          : instruction option;
#         ^^^^^^
# Error: Syntax error
# (cd _build/default && .ppx/6275b1ab6a7c2471cccae8471136173f/ppx.exe --cookie 'library-name="archetype"' -o src/gen_decompile.pp.ml --impl src/gen_decompile.ml -corrected-suffix .ppx-corrected -diff-cmd - -dump-ast)
# File "src/gen_decompile.ml", line 429, characters 7-13:
# 429 |   type effect = [
#              ^^^^^^
# Error: Syntax error
# (cd _build/default && .ppx/6275b1ab6a7c2471cccae8471136173f/ppx.exe --cookie 'library-name="archetype"' -o src/gen_model.pp.ml --impl src/gen_model.ml -corrected-suffix .ppx-corrected -diff-cmd - -dump-ast)
# File "src/gen_model.ml", line 1493, characters 48-54:
# 1493 |       match transaction.transition, transaction.effect with
#                                                        ^^^^^^
# Error: Syntax error
# (cd _build/default && .ppx/6275b1ab6a7c2471cccae8471136173f/ppx.exe --cookie 'library-name="archetype"' -o src/model.pp.ml --impl src/model.ml -corrected-suffix .ppx-corrected -diff-cmd - -dump-ast)
# File "src/model.ml", line 4196, characters 5-11:
# 4196 | type effect = Eadded of ident | Eremoved of ident | Eupdated of ident
#             ^^^^^^
# Error: Syntax error
# (cd _build/default && .ppx/6275b1ab6a7c2471cccae8471136173f/ppx.exe --cookie 'library-name="archetype"' -o src/printer_ast.pp.ml --impl src/printer_ast.ml -corrected-suffix .ppx-corrected -diff-cmd - -dump-ast)
# File "src/printer_ast.ml", line 1155, characters 98-104:
# 1155 |     (pp_option (fun fmt x -> Format.fprintf fmt "effect {@\n  @[%a@]@\n}@\n" pp_instruction x)) t.effect
#                                                                                                          ^^^^^^
# Error: Syntax error
# (cd _build/default && .ppx/6275b1ab6a7c2471cccae8471136173f/ppx.exe --cookie 'library-name="archetype"' -o src/printer_pt.pp.ml --impl src/printer_pt.ml -corrected-suffix .ppx-corrected -diff-cmd - -dump-ast)
# File "src/printer_pt.ml", line 935, characters 34-35:
# 935 | let pp_to fmt ((to_, when_, effect) : (lident * expr option * expr option)) =
#                                         ^
# Error: Syntax error
# (cd _build/default && .ppx/6275b1ab6a7c2471cccae8471136173f/ppx.exe --cookie 'library-name="archetype"' -o src/typing.pp.ml --impl src/typing.ml -corrected-suffix .ppx-corrected -diff-cmd - -dump-ast)
# File "src/typing.ml", line 6232, characters 74-75:
# 6232 | let for_effect ~(ret : A.type_ option) (kind : ekind) (env : env) (effect : PT.expr) =
#                                                                                  ^
# Error: Syntax error

Reported upstream in completium/archetype-lang#367

@mseri
Copy link
Member

mseri commented Dec 12, 2024

I need some time for this. I’d like to fix dune lower bounds before merging

@mseri mseri merged commit e0298eb into ocaml:master Dec 14, 2024
1 of 3 checks passed
@mseri
Copy link
Member

mseri commented Dec 14, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants