Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] moonpool (3 packages) (0.7) #26525

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

c-cube
Copy link
Contributor

@c-cube c-cube commented Sep 10, 2024

Pools of threads supported by a pool of domains

CHANGES:
  • add Moonpool_fiber.spawn_top_ignore
  • add moonpool-io, based on picos_io (still very experimental)
  • move to picos as the foundation layer for concurrency primitives (simon/move to picos c-cube/moonpool#30)
  • move to thread-local-storage 0.2 with get/set API

CHANGES:

- add `Moonpool_fiber.spawn_top_ignore`
- add `moonpool-io`, based on `picos_io` (still very experimental)
- move to picos as the foundation layer for concurrency primitives (c-cube/moonpool#30)
- move to `thread-local-storage` 0.2 with get/set API
@dbuenzli
Copy link
Contributor

It seems an expectation test is failing on 5.0:

# --- a/_build/default/test/fiber/t_fib1.expected
# +++ b/_build/default/test/fiber/t_fib1.output
# @@ -56,6 +56,6 @@ start
#  17: res 6 = 6
#  18: await fiber 7
#  19: main fiber cancelled with Failure("oh no!")
# -20: main fiber result: error Failure("oh no!")
# -21: main fib failed with "oh no!"
# +20: main fib failed with "oh no!"
# +21: main fiber result: error Failure("oh no!")

but the rest seems fine. Any idea @c-cube ?

@c-cube
Copy link
Contributor Author

c-cube commented Sep 10, 2024

Yes this test is sometimes flaky 😩 . It's not a bug. I still don't have a good way to test that part :(.

@dbuenzli
Copy link
Contributor

Well then this seems good to merge. Perhaps disable the test from running on the default suite (if dune allows, no idea).

@mseri mseri merged commit ae77a16 into ocaml:master Sep 10, 2024
2 of 3 checks passed
@mseri
Copy link
Member

mseri commented Sep 10, 2024

Thanks @c-cube and thanks @dbuenzli for the review!

@c-cube c-cube deleted the release-moonpool-v0.7 branch September 11, 2024 04:17
@c-cube
Copy link
Contributor Author

c-cube commented Sep 11, 2024

Thank y'all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants