Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Luv 0.5.14: async I/O #26501

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Luv 0.5.14: async I/O #26501

merged 1 commit into from
Sep 6, 2024

Conversation

aantron
Copy link
Contributor

@aantron aantron commented Sep 5, 2024

From the changelog:

Bugs fixed

@aantron
Copy link
Contributor Author

aantron commented Sep 5, 2024

I don't see yet why the Windows CI failed, but Luv's own Windows CI works and one of the included changes in this release (aantron/luv#160) is towards fixing the Windows build under certain circumstances. I'll try a 5.x build of Luv in Luv's own repo later.

aantron added a commit to aantron/luv that referenced this pull request Sep 5, 2024
aantron added a commit to aantron/luv that referenced this pull request Sep 5, 2024
@aantron
Copy link
Contributor Author

aantron commented Sep 5, 2024

Looks like the deciding factor is not OCaml 5, but using setup-ocaml 3 and dropping the Windows sunset repo. I'll look into that within the Luv repo.

@mseri
Copy link
Member

mseri commented Sep 5, 2024

This should not be a regression. Do you want me to wait or should we merge in the meantime?

@aantron
Copy link
Contributor Author

aantron commented Sep 6, 2024

I think it would be better to merge, if that's ok. I'll figure out the situation with setup-ocaml for next release. Thank you!

@mseri mseri merged commit cad8e0d into ocaml:master Sep 6, 2024
2 of 3 checks passed
@mseri
Copy link
Member

mseri commented Sep 6, 2024

Thanks

@aantron
Copy link
Contributor Author

aantron commented Sep 6, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants