Update the out-of-date opam warning after the release of opam 2.2.1 #26393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avsm
reviewed
Aug 22, 2024
…opam 2.0 Co-authored-by: Anil Madhavapeddy <anil@recoil.org>
dra27
reviewed
Aug 23, 2024
| @@ -4,9 +4,9 @@ upstream: "https://github.com/ocaml/opam-repository/tree/master/" | |||
| announce: [ | |||
| """ | |||
| [WARNING] opam is out-of-date. Please consider updating it (https://opam.ocaml.org/doc/Install.html) | |||
There was a problem hiding this comment.
Apropos this Discuss thread, I think it would be sensible to include the “offending” opam version in the message:
Suggested change
| [WARNING] opam is out-of-date. Please consider updating it (https://opam.ocaml.org/doc/Install.html) | |
| [WARNING] opam %{opam-version}% is out-of-date. Please consider updating it (https://opam.ocaml.org/doc/Install.html) |
| """ | ||
| [INFO] opam 2.1 and 2.2 include many performance improvements over 2.0; please consider upgrading (https://opam.ocaml.org/doc/Install.html) | ||
| [INFO] opam 2.1 and 2.2 include many performance and security improvements over 2.0; please consider upgrading (https://opam.ocaml.org/doc/Install.html) |
There was a problem hiding this comment.
Suggested change
| [INFO] opam 2.1 and 2.2 include many performance and security improvements over 2.0; please consider upgrading (https://opam.ocaml.org/doc/Install.html) | |
| [INFO] opam 2.1 and 2.2 include many performance and security improvements over %{opam-version}%; please consider upgrading (https://opam.ocaml.org/doc/Install.html) |
(similarly; I double-checked that opam 2.0.0 expands variables in post-messages!)
yawaramin
approved these changes
Aug 24, 2024
|
2.2.1 has been released, undrafting. |
|
I missed the udpates above, I will send a separate PR for those |
mseri
added a commit
to mseri/opam-repository
that referenced
this pull request
Aug 27, 2024
Suggested by @dra27 on ocaml#26393 Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
Suggested by @dra27 on ocaml#26393 Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To merge once the Discuss post is published